8000 Force Lyric token refresh on first authentication failure by timmo001 · Pull Request #62100 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Force Lyric token refresh on first authentication failure #62100

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 8 commits into from
Dec 17, 2021
Merged

Force Lyric token refresh on first authentication failure #62100

merged 8 commits into from
Dec 17, 2021

Conversation

timmo001
Copy link
Contributor

Proposed change

Adds logic to force a token refresh if authentication fails on a request. There is an issue with honeywell's servers and oauth tokens which causes tokens which are reported as valid to be invalid. This solves that by forcing the token to refresh.

#61140 (comment)

Type of change

  • Bugfix (non-breaking change which fixes an issue)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • 🥈 Silver

To help with the load of incoming pull requests:

@timmo001 timmo001 closed this Dec 17, 2021
@timmo001 timmo001 reopened this Dec 17, 2021
@MartinHjelmare MartinHjelmare changed the title Honeywell Lyric - Force token refresh on first authentication failure Force Lyric token refresh on first authentication failure Dec 17, 2021
MartinHjelmare
MartinHjelmare approved these changes Dec 17, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@timmo001 timmo001 requested a review from frenck December 17, 2021 11:29
@frenck frenck added this to the 2021.12.4 milestone Dec 17, 2021
@frenck frenck merged commit 0f2a3c0 into home-assistant:dev Dec 17, 2021
@timmo001 timmo001 deleted the lyric-fix-oauth branch December 17, 2021 15:23
@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: lyric
Projects
None yet
Milestone
2021.12.4
Development

Successfully merging this pull request may close these issues.

Honeywell Lyric becomes unavailable
5 participants
@timmo001 @frenck @MartinHjelmare @balloob @homeassistant
0