8000 Avoid setting nexia humidity to the same value since it causes the api to fail by bdraco · Pull Request #61843 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Avoid setting nexia humidity to the same value since it causes the api to fail #61843

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 19, 2021
Merged

Avoid setting nexia humidity to the same value since it causes the api to fail #61843

merged 2 commits into from
Dec 19, 2021

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Dec 15, 2021 •
edited
Loading

Proposed change

SSIA

Changelog: bdraco/nexia@0.9.11...0.9.12

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco changed the title Set PARALLEL_UPDATES to 1 for nexia to avoid timeout errors Avoid setting nexia humidity to the same value since it causes the api to fail Dec 17, 2021
@bdraco bdraco added this to the 2021.12.4 milestone Dec 17, 2021
@bdraco bdraco marked this pull request as ready for review December 17, 2021 16:35
@bdraco
Copy link
Member Author
bdraco commented Dec 17, 2021

I need to add the change log link but mobile now so will do when I get home

balloob
balloob approved these changes Dec 18, 2021
View reviewed changes
Copy link
Member
@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's an annoying API quirk

@balloob balloob merged commit 7764c95 into home-assistant:dev Dec 19, 2021
balloob pushed a commit that referenced this pull request Dec 20, 2021
@bdraco @balloob
Avoid setting nexia humidity to the same value since it causes the ap…
4e96ff7 
…i to fail (#61843)
@balloob balloob mentioned this pull request Dec 20, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed integration: nexia small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.4
Development

Successfully merging this pull request may close these issues.

Nexia plug in HA Core not setting Stat correctly when used in HK Automation or Scene
3 participants
@bdraco @balloob @homeassistant
0