Only publish nest camera event messages once per thread and bump nest version #61587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bump google-nest-sdm to 0.4.6 to support event threading. A thread is an event message published to update an existing event, usually containing duplicate information from the previous event. An event is first published in STARTED then followed up with an ENDED state. See https://developers.google.com/nest/device-access/release-notes?hl=en#september_21_2021 for release notes and https://developers.google.com/nest/device-access/api/events?hl=en#updateable-notifications for details on the event messages. As a first pass, this is not trying to be fancy about publishing events that contain diffs for new event types in the thread (e.g. first motion, then person), however the internal nest event media state is correctly updated to reflect all events in the thread.
balloob
approved these changes
Dec 12, 2021
|
I'm missing a link to the Github release or commit compare range for the version bump in the PR description. |
I've updated the PR description with the link, and here it is for your convenience allenporter/python-google-nest-sdm@0.4.5...0.4.6 It contains one significant change which pushes the subscribe callback deeper into the event media management library where it keeps state about which event messages have been received, and suppresses in some scenarios. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Bump google-nest-sdm to 0.4.6 to support event threading. A thread is an event
message published to update an existing event, usually containing duplicate
information from the previous event. An event is first published in STARTED
then followed up with an ENDED state.
This effectively makes it possible to drive automations for nest battery cameras, otherwise you get duplicate events published. Note: For media source, we already only fetch media once since it is cached based on the event session id, so this is purely to make automations work better. Including in the next release milestone since it will help users make automations for battery cam clips.
See https://developers.google.com/nest/device-access/release-notes?hl=en#september_21_2021 for release notes and https://developers.google.com/nest/device-access/api/events?hl=en#updateable-notifications for details on the event
messages.
As a first pass, this is not trying to be fancy about publishing events that contain diffs
for new event types in the thread (e.g. first motion, then person), however the internal nest event media state is correctly updated to reflect all events in the thread.
allenporter/python-google-nest-sdm@0.4.5...0.4.6
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: