8000 Fix Hue transition calculation by marcelveldt · Pull Request #61581 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Hue transition calculation #61581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 12, 2021
Merged

Fix Hue transition calculation #61581

merged 1 commit into from
Dec 12, 2021

Conversation

marcelveldt
Copy link
Member

Proposed change

Fix the transition calculation for Hue lights which should be provided in milliseconds and not a number of 100 ms.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@marcelveldt marcelveldt requested a review from balloob as a code owner December 12, 2021 15:26
@probot-home-assistant
Copy link

Hey there @balloob, mind taking a look at this pull request as it has been labeled with an integration (hue) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@marcelveldt marcelveldt added this to the 2021.12.1 milestone Dec 12, 2021
@balloob balloob merged commit 4ad90b3 into home-assistant:dev Dec 12, 2021
balloob pushed a commit that referenced this pull request Dec 12, 2021
@marcelveldt @balloob
Fix Hue transition calculation (#61581)
0924874
@balloob balloob mentioned this pull request Dec 12, 2021
Merged
@sdebruyn sdebruyn mentioned this pull request Dec 13, 2021
Merged
@golles golles mentioned this pull request Dec 13, 2021
Closed
@Flash3dee
Copy link

Don't know where to post this but 2021.12.1 seems to have the same issue as 12.0. Transition times are still not correct. Using them with rooms and zones. 200 seconds is reduced to a second or 2.

@marcelveldt
Copy link
Member Author

Don't know where to post this but 2021.12.1 seems to have the same issue as 12.0. Transition times are still not correct. Using them with rooms and zones. 200 seconds is reduced to a second or 2.

Please do not reply on closed PR's. There's another fix coming up for zones/rooms, see #61714.
Once that fix is released (hopefully in 2021.12.2) open a new issue if it's not fixed. Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees

@balloob balloob

Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: hue small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.12.1
Development

Successfully merging this pull request may close these issues.

Transition times not behaving as expected. 15 min transition is completed in under a minute.
4 participants
@marcelveldt @Flash3dee @balloob @homeassistant
0