8000 Clean up value_added in zwave light. by andrey-git · Pull Request #6074 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Clean up value_added in zwave light. #6074 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 18, 2017
Merged

Clean up value_added in zwave light. #6074

merged 1 commit into from
Feb 18, 2017

Conversation

andrey-git
Copy link
Contributor
@andrey-git andrey-git commented Feb 17, 2017 •
edited
Loading

Description:

Clean up value_added in zwave light.

Now schedule_update_ha_state is called if we came after a refresh.
If we are starting a refresh it is not called (was called before).

I think the previous behavior doesn't make sense: we want to update state when think we have good data - i.e. after refresh.

If the code does not interact with devices:

  • Local tests with tox run successfully. Your PR cannot be merged unless tests pass

@mention-bot
Copy link

@andrey-git, thanks for your PR! By analyzing the history of the files in this pull request, we identified @armills, @leoc and @turbokongen to be potential reviewers.

emlove
emlove approved these changes Feb 17, 2017
View reviewed changes
Copy link
Contributor
@emlove emlove left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. We should note that the behavior change here is that schedule_update_ha_state is not called if a refresh is pending, but I think that's appropriate.

@pvizeli
Copy link
Member
pvizeli commented Feb 17, 2017

What is about #5961 ?

@andrey-git
Copy link
Contributor Author

@armills
Now schedule_update_ha_state is called if we came after a refresh.
If we are starting a refresh it is not called (was called before).

I think the previous behavior doesn't make sense: we want to update state when think we have good data - i.e. after refresh.

@pvizeli unrelated to #5961

@emlove
Copy link
Contributor
emlove commented Feb 17, 2017

I agree 100%. Just wanted to note the behavior change so everyone else doesn't need to figure it out.

@balloob balloob merged commit c1eed14 into home-assistant:dev Feb 18, 2017
@andrey-git andrey-git deleted the cleanup branch February 18, 2017 07:58
@home-assistant home-assistant locked and limited conversation to collaborators Jun 2, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@emlove emlove emlove approved these changes

Assignees
No one assigned
Labels
cla-signed integration: zwave
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@andrey-git @mention-bot @pvizeli @emlove @balloob @homeassistant
0