8000 Constrain urllib3 to >=1.26.5 by frenck · Pull Request #59043 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Constrain urllib3 to >=1.26.5 #59043

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 4, 2021
Merged

Constrain urllib3 to >=1.26.5 #59043

merged 3 commits into from
Nov 4, 2021

Conversation

frenck
Copy link
Member
@frenck frenck commented Nov 4, 2021

Proposed change

Ensures we don't run into these CVEs

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added core dependency small-pr PRs with less than 30 lines. labels Nov 4, 2021
@frenck frenck added this to the 2021.11.1 milestone Nov 4, 2021
@frenck frenck merged commit 32784d1 into dev Nov 4, 2021
@frenck frenck deleted the frenck-2021-2736 branch November 4, 2021 10:21
balloob pushed a commit that referenced this pull request Nov 5, 2021
@frenck @balloob
Constrain urllib3 to >=1.26.5 (#59043)
433743b
@balloob balloob mentioned this pull request Nov 5, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Nov 6, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core dependency dependency-bump small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.11.1
Development

Successfully merging this pull request may close these issues.
4 participants
@frenck @MartinHjelmare @balloob @homeassistant
0