8000 Bump spiderpy to 1.4.3 by peternijssen · Pull Request #57675 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump spiderpy to 1.4.3 #57675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 14, 2021
Merged

Bump spiderpy to 1.4.3 #57675

merged 1 commit into from
Oct 14, 2021

Conversation

peternijssen
Copy link
Contributor

Proposed change

This updates the dependency of spiderpy to 1.4.3, which contains a fix for logging in. Would love to see this PR go in the next minor release of HA.

Changes: peternijssen/spiderpy@1.4.2...1.4.3

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@peternijssen peternijssen changed the title Update spiderpy dependency to 1.4.3 Bump spiderpy to 1.4.3 Oct 14, 2021
@frenck frenck added this to the 2021.10.5 milestone Oct 14, 2021
frenck
frenck approved these changes Oct 14, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @peternijssen 👍

Happy Hacktoberfest 🎉

../Frenck

@frenck frenck merged commit f8ea2f9 into home-assistant:dev Oct 14, 2021
janiversen pushed a commit to janiversen/core that referenced this pull request Oct 15, 2021
@peternijssen @janiversen
Bump spiderpy to 1.4.3 (home-assistant#57675)
49b2bf6
balloob pushed a commit that referenced this pull request Oct 15, 2021
@peternijssen @balloob
Bump spiderpy to 1.4.3 (#57675)
51e204a
@balloob balloob mentioned this pull request Oct 15, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 16, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed dependency dependency-bump Hacktoberfest integration: spider small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.10.5
Development

Successfully merging this pull request may close these issues.

API url of the spider integration suddenly changed
4 participants
@peternijssen @frenck @balloob @homeassistant
0