8000 Detect if mysql and sqlite support row_number by emontnemery · Pull Request #57475 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Detect if mysql and sqlite support row_number #57475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 12, 2021
Merged

Detect if mysql and sqlite support row_number #57475

merged 2 commits into from
Oct 12, 2021

Conversation

emontnemery
Copy link
Contributor
@emontnemery emontnemery commented Oct 11, 2021 •
edited
Loading

Proposed change

Disable use of the row_number() windowing function for old mysql and sqlite versions

This restores compatibility with MySql/MariaDB pre 5.8 and SQLite pre 3.25

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@emontnemery emontnemery requested a review from a team as a code owner October 11, 2021 09:56
@probot-home-assistant
Copy link

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (recorder) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

This was referenced Oct 11, 2021
Closed
Closed
@emontnemery emontnemery added this to the 2021.10.4 milestone Oct 11, 2021
@balloob balloob merged commit 0139bfa into dev Oct 12, 2021
@balloob balloob deleted the recorder_mysql_pre_8_workaround branch October 12, 2021 04:17
balloob pushed a commit that referenced this pull request Oct 12, 2021
@emontnemery @balloob
Detect if mysql and sqlite support row_number (#57475)
6db010f
@balloob balloob mentioned this pull request Oct 12, 2021
Merged
@SigmundDewachtere SigmundDewachtere mentioned this pull request Oct 12, 2021
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix cherry-picked cla-signed core Hacktoberfest has-tests integration: recorder integration: sensor
Projects
None yet
Milestone
2021.10.4
Development

Successfully merging this pull request may close these issues.
3 participants
@emontnemery @balloob @homeassistant
0