8000 Fix referenced before assignment in modem_callerid by tkdrob · Pull Request #57460 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix referenced before assignment in modem_callerid #57460

8000
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 11, 2021
Merged

Fix referenced before assignment in modem_callerid #57460

merged 1 commit into from
Oct 11, 2021

Conversation

tkdrob
Copy link
Contributor
@tkdrob tkdrob commented Oct 11, 2021 •
edited
Loading

Breaking change

Proposed change

I seemed to have missed this referenced before assignment error during my testing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Oct 11, 2021
@frenck frenck added this to the 2021.10.4 milestone Oct 11, 2021
frenck
frenck approved these changes Oct 11, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @tkdrob 👍

@frenck frenck merged commit 8275110 into home-assistant:dev Oct 11, 2021
@tkdrob tkdrob deleted the modem_callerid_patch branch October 11, 2021 10:08
balloob pushed a commit that referenced this pull request Oct 12, 2021
@tkdrob @balloob
Fix referenced before assignment in modem_callerid (#57460)
fd657e5
@balloob balloob mentioned this pull request Oct 12, 2021
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Oct 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed Hacktoberfest integration: modem_callerid small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
2021.10.4
Development

Successfully merging this pull request may close these issues.
4 participants
@tkdrob @frenck @balloob @homeassistant
0