Add wemo options enable_subscription & enable_long_press #56972
Conversation
f52177a to
f982054
Compare
6ba5d13 to
7c021ea
Compare
7c021ea to
9a74475
Compare
|
I've switched this PR from a feature request to a bug fix. Allowing users to disable push subscriptions fixes #62224. |
9a74475 to
7d770a5
Compare
7d770a5 to
6fd1064
Compare
|
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
|
Also following closely. Randomly having wemos fall off of HA and was close to abandoning my wemos for zwave tonight. Would rather see if there's a potential fix as wemos are much more affortable. |
|
Hi, @frenck. Is there more the contributor needs to do to get this in shape to merge? Thank you. |
|
Thanks @silverl for asking. I've seen the devs do not like to be pinged, so I've just been waiting (on this and other PRs). I'm not sure what more there is to do. This code has been running fine on my HA instance for over a year. But maybe this PR doesn't fit well with the HA config model? I'm happy to change it or re-implement it if given some guidance. |
|
Hi, @esev. Is it hard to replace the native WeMo integration with the modified copy? I'm game to try, but not sure where to start. |
|
I think it is possible to take a copy of this code and add it to the custom_components directory. But I haven't done that before. Searching for custom_components may bring up some solutions. I have a different process where I patch this (and other) code into the monthly official Docker images and produce a new Docker image that contains my code. That makes rollbacks easy/safe for me should I need to go back to a prior release. That's not as easy of a process as I believe custom_components may be. |
|
Anything left to do here? It looks like someone approved the changes... |
There was a problem hiding this comment.
Code looks good to me.
I do agree with the fact that its cumbersome to ask the user for these kind of options but at the same time understand its hard to detect this properly and by having these options you at least have a solution for users affected by this.
Do note that options like this make the code more complicated and thus harder to maintain in the long run so if you ever find a way to solve it without this, fix it in a future PR ;-)
BTW: The issue sounds to me like device specific (malfunctioning device) or maybe even network related.
|
@esev sorry for the delay, we're swamped with PR's and so hard to catch up with reviews. Are you ready for a final review so we can get this merged ? In that case please rebase the PR one more time so its up to date with the dev branch again. For now, I've marked this PR as draft, awaiting your response. Thanks! 👍 |
8a03427 to
e5b2d38
Compare
|
Many thanks for the review! It's much appreciated. I rebased and fixed two issues. It should be good for a final review now. |
74340da to
6493772
Compare
bbae206
into
home-assistant:dev
<
A3E2
relative-time datetime="2023-06-27T18:10:14Z" class="no-wrap">Jun 27, 2023
Proposed change
Adding ConfigFlow options for Wemo to control subscriptions and the long-press feature.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: