8000 Make use of entry id rather than unique id when storing deconz entry in hass.data by Kane610 · Pull Request #52584 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Make use of entry id rather than unique id when storing deconz entry in hass.data #52584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 6, 2021
Merged

Make use of entry id rather than unique id when storing deconz entry in hass.data #52584

merged 2 commits into from
Jul 6, 2021

Conversation

Kane610
Copy link
Member
@Kane610 Kane610 commented Jul 6, 2021

Breaking change

Proposed change

The user of #52326 seems to have been able to get an entry to run without a unique id, even though it is not supported it shows its better to not depend on it for the case of storing it internally.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@Kane610 Kane610 changed the title Make use of entry id rather than unique id when storing entry in hass.data Make use of entry id rather than unique id when storing deconz entry in hass.data Jul 6, 2021
@Kane610 Kane610 added this to the 2021.7.0 milestone Jul 6, 2021
@Kane610 @frenck
Update homeassistant/components/deconz/services.py
2c3d748 
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
frenck
frenck approved these changes Jul 6, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Kane610 👍

@frenck frenck merged commit 605f65b into home-assistant:dev Jul 6, 2021
@Kane610
Copy link
Member Author
Kane610 commented Jul 6, 2021

Thanks @frenck 🎉

frenck added a commit that referenced this pull request Jul 6, 2021
@Kane610 @frenck
Make use of entry id rather than unique id when storing deconz entry …
7a503a6 
…in hass.data (#52584)

* Make use of entry id rather than unique id when storing entry in hass data

* Update homeassistant/components/deconz/services.py

Co-authored-by: Franck Nijhof <frenck@frenck.nl>

Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@github-actions github-actions bot locked and limited conversation to collaborators Jul 7, 2021
@Kane610 Kane610 deleted the deconz-store_integration_in_entry_id branch July 8, 2021 13:55
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
by-code-owner cherry-picked cla-signed code-quality has-tests integration: deconz small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@Kane610 @frenck @homeassistant
0