Revert nmap_tracker to 2021.6 version #52573
Conversation
- Its unlikely we will be able to solve home-assistant#52565 before release
|
I've tested and reviewed this revert, it looks and works OK (tested it for existing beta users). |
|
if I may ask, why would you want to revert, based on 1 report of slowing down? Tbh, in my current 2021.7.b03 setup, no slowing down is noticed at all, tracking 71 devices/entities find the new config and UI editing a huge improvement over the yaml config, 8000 and would really feel sorry if this would be reverted |
|
IMHO, A report of a hard crash from any credible source is reason enough for a revert. It's better to spend time to investigate than potentially have it happen widespread. |
|
fair enough. Its just that no one else in the beta channel on Discord reported this |
There was a problem hiding this comment.
Initial tests against the patched Python version, showed no change in behavior. The behavior was reproducible and the same for the current image vs the newly created image.
The patch has therefore been reverted in docker-base#147.
At this point, considering the fairly high use of this integration (it is in the top 100); I think we should not risk general system stability, thus making the call to merge in PR for 2021.7, effectively reverting the NMap upgrade.
* Revert nmap_tracker to 2021.6 version - Its unlikely we will be able to solve #52565 before release * hassfest
Proposed change
Revert nmap_tracker to 2021.6 version
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: