8000 DSMR: Device/state classes, icons, less common disabled by default by frenck · Pull Request #52159 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

DSMR: Device/state classes, icons, less common disabled by default #52159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 24, 2021
Merged

DSMR: Device/state classes, icons, less common disabled by default #52159

merged 1 commit into from
Jun 24, 2021

Conversation

frenck
Copy link
Member
@frenck frenck commented Jun 24, 2021

Proposed change

This PR adds a bunch of properties to the existing DSMR sensors and refactors/removes logic for the current entity icon.

  • Adds device_class to sensors if there is a matching one
  • Adds state_class to sensors if it is a measurement
  • Adds last_reset to sensors that are fixed measurements
  • Adds icon to sensors that don't have a device class set
  • Disabled less common sensors by default

Some next steps after this PR:

  • Strict typing / fully complete typing.
  • Refactor the tests a little
  • Update documentation to be more user-centric.
  • Use dispatch helper to distribute telegram to entities.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @RobBie1221, mind taking a look at this pull request as its been labeled with an integration (dsmr) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck merged commit 34a317b into dev Jun 24, 2021
@frenck frenck deleted the frenck-2021-1868 branch June 24, 2021 16:48
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: dsmr new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frenck @balloob @homeassistant
0