Add zwave_js options flow to reconfigure server #51840
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration ( |
9 tasks
ap
8000
pleguru
approved these changes
Jun 20, 2021
emontnemery
approved these changes
Jun 22, 2021
Comment on lines
+1175
to
+1181
| {"device": "/test", "network_key": "abc123"}, | ||
| { | ||
| "usb_path": "/new", | ||
| "network_key": "new123", | ||
| "log_level": "info", | ||
| "emulate_hardware": False, | ||
| }, |
There was a problem hiding this comment.
Just a side note:
old_addon_options and new_addon_options are same in both parametrizations, but it's nice for clarity to specify them here.
Is there some nice pattern to avoid duplicating them though?
There was a problem hiding this comment.
We could store them in two constants. For most of these tests it's mostly needed to see that the old is different from the new options, not exactly what the difference is. There are some exceptions where the details are interesting.
MartinHjelmare
commented
Jun 22, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
TODO
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: