8000 Add Xiaomi Miio EU gateway support by starkillerOG · Pull Request #47955 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add Xiaomi Miio EU gateway support #47955

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 62 commits into from
Jun 14, 2021
Merged

Add Xiaomi Miio EU gateway support #47955

merged 62 commits into from
Jun 14, 2021

Conversation

starkillerOG
Copy link
Contributor
@starkillerOG starkillerOG commented Mar 15, 2021 •
edited
Loading

Breaking change

Proposed change

Add support for subdevices of the EU gateway through getting the subdevice list from the mi cloud.
This adds an options flow and adds micloud==0.3 to the requirements.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Config flow

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @rytilahti, @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_miio) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

This was referenced Mar 15, 2021
Merged
Open
@MartinHjelmare MartinHjelmare changed the title Xiaomi Miio: Add EU gateway support Add Xiaomi Miio EU gateway support Mar 15, 2021
@starkillerOG
Copy link
Contributor Author

Alright I have tested the code on my dev enviroment and everything seems to work.
This schould enable EU_gateways to use subdevices because the connected subdevices can now be obtained through the cloud.

For anyone who want to test this code (with an EU gateway), just download the homeassistant/components/xiaomi_miio folder from https://github.com/starkillerOG/home-assistant/tree/Miio_eu_gateway and place that folder in your homeassistant config/custom_components folder.

@starkillerOG
Copy link
Contributor Author

@syssi, @rytilahti could you revieuw this PR?
I think a lot of users have been waiting for this a long time (to get there EU gateways working)

@starkillerOG
Copy link
Contributor Author

@frenck / @MartinHjelmare this is ready for revieuw/merge

@frenck
Copy link
Member
frenck commented Jun 5, 2021

@frenck / @MartinHjelmare this is ready for revieuw/merge

Almost 😉

@starkillerOG
Copy link
Contributor Author

Finally all tests pass, sorry about that.

MartinHjelmare
MartinHjelmare reviewed Jun 5, 2021
View reviewed changes
starkillerOG and others added 10 commits June 5, 2021 17:04
@starkillerOG @MartinHjelmare
fix spelling
ab7df97 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@starkillerOG @MartinHjelmare
Fix spelling
b03c921 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@starkillerOG @MartinHjelmare
fix spelling
8747739 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@starkillerOG @MartinHjelmare
remove unessesary .keys()
a609f4f 
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
@starkillerOG
combine async_add_executor_job calls
1db97fc
@starkillerOG
Merge branch 'Miio_eu_gateway' of https://github.com/starkillerOG/hom…
01bbde7 
…e-assistant into Miio_eu_gateway
@starkillerOG
remove async_step_model
a6bd9e8
@starkillerOG
fix wrong indent
03ef56d
@starkillerOG
fix gatway.py
335e837
@starkillerOG
fix tests
fd558bb
@starkillerOG
Copy link
Contributor Author

@MartinHjelmare I processed all comments, any more feedback?

MartinHjelmare
MartinHjelmare approved these changes Jun 6, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@starkillerOG
Copy link
Contributor Author

@frenck could you also revieuw/merge?

@frenck
Copy link
Member
frenck commented Jun 14, 2021

Taking a look now!

frenck
frenck approved these changes Jun 14, 2021
View reviewed changes
Copy link
Member
@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! This is going to make it so much easier for people 🥇

@frenck frenck merged commit 3a2d50f into home-assistant:dev Jun 14, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jun 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ntilley905 ntilley905 ntilley905 requested changes

@frenck frenck frenck approved these changes

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@syssi syssi

@rytilahti rytilahti

Labels
by-code-owner cla-signed integration: xiaomi_miio new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@starkillerOG @marioskamperis @frenck @MartinHjelmare @ntilley905 @syssi @rytilahti @homeassistant
0