8000 Correct climacell device info by raman325 · Pull Request #47292 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Correct climacell device info #47292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 3, 2021
Merged

Correct climacell device info #47292

merged 1 commit into from
Mar 3, 2021

Conversation

raman325
Copy link
Contributor
@raman325 raman325 commented Mar 3, 2021

Proposed change

Meant to fix this in #47286 but moved too quickly. Mainly fixes the device name which used to include one of the forecast types which doesn't make sense.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

MartinHjelmare
MartinHjelmare approved these changes Mar 3, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit 6019bcf into home-assistant:dev Mar 3, 2021
@frenck frenck added this to the 2021.3.0 milestone Mar 3, 2021
frenck pushed a commit that referenced this pull request Mar 3, 2021
@raman325 @frenck
Correct climacell device info (#47292)
24919e9
@github-actions github-actions bot locked and limited conversation to collaborators Mar 4, 2021
@raman325 raman325 deleted the fix_device_info branch April 4, 2021 19:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: climacell small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@raman325 @MartinHjelmare @frenck @homeassistant
0