8000 Add raw values to zwave_js value notification event by raman325 · Pull Request #47258 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add raw values to zwave_js value notification event #47258

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 2, 2021
Merged

Add raw values to zwave_js value notification event #47258

merged 2 commits into from
Mar 2, 2021

Conversation

raman325
Copy link
Contributor
@raman325 raman325 commented Mar 2, 2021 •
edited
Loading

Proposed change

Currently, we include property_name, property_key_name, and the state level for the value in the notification. This PR adds the "raw" integer values to the event to give users maximum flexibility on how they set up their automations.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @home-assistant/z-wave, mind taking a look at this pull request as its been labeled with an integration (zwave_js) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@raman325 raman325 mentioned this pull request Mar 2, 2021
Merged
8 tasks
@raman325 raman325 merged commit 42af775 into home-assistant:dev Mar 2, 2021
@raman325 raman325 deleted the value_raw branch March 2, 2021 21:10
@raman325 raman325 added this to the 2021.3.0 milestone Mar 2, 2021
balloob pushed a commit that referenced this pull request Mar 2, 2021
@raman325 @balloob
Add raw values to zwave_js value notification event (#47258)
6c5c323 
* add value_raw to value notification event that always shows the untranslated state value

* add property key and property to event params
@github-actions github-actions bot locked and limited conversation to collaborators Mar 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
cherry-picked cla-signed has-tests integration: zwave_js new-feature small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
2021.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@raman325 @balloob @homeassistant
0