8000 Fix typing of fan speed count and steps by bdraco · Pull Request #46790 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix typing of fan speed count and steps #46790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Feb 20, 2021
Merged

Fix typing of fan speed count and steps #46790

merged 6 commits into from
Feb 20, 2021

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Feb 19, 2021 •
edited
Loading

Proposed change

Typing fixes for fan speed count and steps

Follow up to fix typing from #46512

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@bdraco bdraco mentioned this pull request Feb 19, 2021
Merged
21 tasks
MartinHjelmare
MartinHjelmare reviewed Feb 19, 2021
View reviewed changes
@MartinHjelmare MartinHjelmare changed the title Typing fixes for fan speed count and steps Fix typing for fan speed count and steps Feb 19, 2021
@MartinHjelmare MartinHjelmare changed the title Fix typing for fan speed count and steps Fix typing of fan speed count and steps Feb 19, 2021
bdraco
bdraco commented Feb 19, 2021
View reviewed changes
bdraco
bdraco commented Feb 19, 2021
View reviewed changes
bdraco
bdraco commented Feb 19, 2021
View reviewed changes
MartinHj 8000 elmare
MartinHjelmare approved these changes Feb 19, 2021
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@bdraco bdraco merged commit 3e334a4 into home-assistant:dev Feb 20, 2021
@bdraco bdraco deleted the fan_typing branch February 20, 2021 05:57
@github-actions github-actions bot locked and limited conversation to collaborators Feb 21, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bdraco @MartinHjelmare @homeassistant
0