Better locking while setting up components + discovery #4463
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Nov 19, 2016
| @@ -1,7 +1,10 @@ | |||
| """Test discovery helpers.""" | |||
| import asyncio | |||
3023f03 to
5d40e12
Compare
This was referenced Nov 19, 2016
balloob
commented
Nov 19, 2016
| # Convert values to dictionaries if they are None | ||
| config = defaultdict( | ||
| dict, {key: value or {} for key, value in config.items()}) | ||
| new_config = OrderedDict() |
There was a problem hiding this comment.
I always thought that we setup everything with an ordered dict but looks like I was wrong. Instead we converted everything to a normal dictionary, making each setup unpredictable.
MartinHjelmare
previously requested changes
Nov 19, 2016
There was a problem hiding this comment.
Nice! One typo in a docstring.
What about the lock here:
https://github.com/home-assistant/home-assistant/blob/5d40e12639e71467584a467a7f2fc3e8e8bf691d/homeassistant/bootstrap.py#L98-L177
Do we still need that?
| There are two different types of discoveries that can be fired/listened for. | ||
| - listen/discover is for services. These are targetted at a component. | ||
| - listen_platform/discover_platform is for platforms. These are used by | ||
| components to allow discovery of their platofrms. |
|
For now we will still need that that lock in case people do not use the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This improves locking to avoid running parallel component setups during startup and discovery.
Related issue (if applicable): #4435 #4014
Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass