device_tracker.see should not call async methods #4377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC @lwis |
|
Crap, sorry. Curious, why didn't the test pick this up? |
|
It only emits a warning, not an error. |
|
My bad. It is raising exceptions. But maybe that's only on certain event loops. This is a log from UV loop that did raise: http://paste.ofcode.org/9pCwKVPWQw5Ti8ymC3GqhY |
|
Auch, this is actually an even bigger bug then I thought. We are firing |
balloob
added a commit
that referenced
this pull request
Nov 15, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The device_tracker
seemethod that is passed into platforms is not async friendly. However it was making 1 call to a method that was async. This PR fixes it.Reported by @bbangert on Gitter. http://paste.ofcode.org/329QM5hKqd3RGCZcMq2EEBu