8000 Play status fix in Yamaha receivers by postlund · Pull Request #4281 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Play status fix in Yamaha receivers #4281

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

postlund
Copy link
Contributor
@postlund postlund commented Nov 7, 2016

Description:
Simple fix for receivers that does not support play status information.

Related issue (if applicable): fixes #4226

@mention-bot
Copy link

@postlund, thanks for your PR! By analyzing the history of the files in this pull request, we identified @aoakeson, @sdague and @TheRealLink to be potential reviewers.

@sdague
Copy link
Contributor
sdague commented Nov 7, 2016

Tentative +1 on this, though it would be good to know this fixes the issue as reported by @Kernald first before merging.

@balloob
Copy link
Member
balloob commented Nov 8, 2016

@sdague, can you be in charge of this PR? 👍

@postlund
Copy link
Contributor Author
postlund commented Nov 8, 2016

As @sdague have a better solution in #4226 (making changes to rxv instead), I suggest that we reject my PR and wait for a new version of rxv instead. I assume @sdague agree as well?

@sdague
Copy link
Contributor
sdague commented Nov 8, 2016

@balloob yes, but I think we've got a better fix in the core library. I'm going to just close out this PR.

@sdague sdague closed this Nov 8, 2016
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0.32 broke media_player.yamaha
4 participants
0