8000 Update greeclimate to 0.9.2 by cmroche · Pull Request #42616 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Update greeclimate to 0.9.2 #42616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 29, 2020
Merged

Update greeclimate to 0.9.2 #42616

merged 1 commit into from
Oct 29, 2020

Conversation

cmroche
Copy link
Contributor
@cmroche cmroche commented Oct 29, 2020

Fixes issue with erroneous await in UDP recv queue

Proposed change

Updating greeclimate package to version 0.9.2 Release Notes which fixes a bug where an erroneous await was emitting a traceback in rare cases when receiving UDP data when multiple Gree devices where present on the network.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cmroche
Update greeclimate to 0.9.2
9553721 
Fixes issue with erroneous await in UDP recv queue
springstan
springstan approved these changes Oct 29, 2020
View reviewed changes
Copy link
Member
@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 @cmroche should we tag this for 0.117.1?

@cmroche
Copy link
Contributor Author
cmroche commented Oct 29, 2020

@springstan Yes, I think it would be good to put in 0.117.1

@springstan springstan added this to the 0.117.1 milestone Oct 29, 2020
@springstan springstan merged commit 3a11e2c into home-assistant:dev Oct 29, 2020
@cmroche cmroche deleted the gree-fixes-20201029 branch October 29, 2020 23:50
balloob pushed a commit that referenced this pull request Oct 30, 2020
@cmroche @balloob
Update greeclimate to 0.9.2 (#42616)
26766d6 
Fixes issue with erroneous await in UDP recv queue
@balloob balloob mentioned this pull request Oct 30, 2020
Merged
@hemingfei hemingfei mentioned this pull request Nov 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springstan springstan springstan approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency dependency-bump Hacktoberfest integration: gree small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
< 4828 /span> 0.117.1
Development

Successfully merging this pull request may close these issues.

HA 117 problems
4 participants
@cmroche @springstan @balloob @homeassistant
0