Remove broken disable verify ssl synology #4269
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There are still issues with the cookies that are going to prevent the component from working. It all stems from the switch to aiohttp. I've got a working fix running on my own dev system, but need to cleanup the code and do some more testing before I can do a PR. It looks like cookies and ssl_verify need to be set in the client connection, so I'm setting up my own instead of using hass.websessions |
|
If you could PR this, that would be great 👍 |
|
http://aiohttp.readthedocs.io/en/stable/client_reference.html#basic-api cookies should work on request... |
|
I thought so too, but I was getting error about an unexpected argument, cookies, until I created my own clientsession and passed it there. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Disabling SSL verification for Synology camera's has been broken in 0.32 as reported in #4257. I don't have time for a proper fix right now so will just ensure now that it at least works with SSL verification enabled.
Related issue (if applicable): #4257