8000 Enable polling for DSMR derivative entity by RobBie1221 · Pull Request #42524 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Enable polling for DSMR derivative entity #42524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 30, 2020
Merged

Enable polling for DSMR derivative entity #42524

merged 2 commits into from
Oct 30, 2020

Conversation

RobBie1221
Copy link
Contributor
@RobBie1221 RobBie1221 commented Oct 28, 2020 •
edited
Loading

Breaking change

Proposed change

Polling was disabled for DSMREntity in #42108 (because force_update was set in #42086). The DerivativeDSMREntity, which uses DSMREntity as base class however does need polling. As a consequence, this entity is not updated anymore. This PR enables polling again as fix.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@RobBie1221
Copy link
Contributor Author

Can this be tagged for 0.117.1?

@RobBie1221 RobBie1221 force-pushed the fix_dsmr_der_entity branch 3 times, most recently from 5f38e88 to e7c27d2 Compare October 29, 2020 21:52
@balloob balloob added this to the 0.117.1 milestone Oct 30, 2020
@balloob balloob merged commit f470d1e into home-assistant:dev Oct 30, 2020
@RobBie1221 RobBie1221 deleted the fix_dsmr_der_entity branch October 30, 2020 08:16
balloob pushed a commit that referenced this pull request Oct 30, 2020
@RobBie1221 @balloob
Enable polling for DSMR derivative entity (#42524)
048db9c
@balloob balloob mentioned this pull request Oct 30, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed Hacktoberfest integration: dsmr small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.117.1
Development

Successfully merging this pull request may close these issues.

Component dsmr state sensor.hourly_gas_consumption is unknown
3 participants
@RobBie1221 @balloob @homeassistant
0