Tweak block_till_done #4245
Merged
Tweak block_till_done #4245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@balloob, thanks for your PR! By analyzing the history of the files in this pull request, we identified @pvizeli, @fabianhjr and @jaharkes to be potential reviewers. |
8000
pvizeli
approved these changes
Nov 6, 2016
|
Yeah I also see that on travis. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every time you refer to a weakmap it will remove all entries that no longer exist. In our block_till_done method we referred to it twice and it could happen that the map became empty between the time that we checked the length and it got passed into
asyncio.wait, causingasyncio.waitto raise an error.