Cleanup use of MQTT in emulated_hue tests #4068
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches the test_emulated_hue module to use unix newlines instead of the DOS style that were there before. (using dos2unix on the file) This makes it consistent with the other files in the repo.
|
@mtreinish, thanks for your PR! By analyzing the history of the files in this pull request, we identified @mgbowen and @fabaff to be potential reviewers. |
balloobbot
reviewed
Oct 26, 2016
|
|
||
| from homeassistant import bootstrap, const, core | ||
| import homeassistant.components as core_components | ||
| from homeassistant.components import emulated_hue, http, light, mqtt |
There was a problem hiding this comment.
- 1: F401 'homeassistant.components.mqtt' imported but unused
balloobbot
reviewed
Oct 26, 2016
|
|
||
|
|
||
|
|
||
| def setup_hass_instance(emulated_hue_config): |
There was a problem hiding this comment.
- 1: E303 too many blank lines (3)
balloobbot
reviewed
Oct 26, 2016
| data = {'key1': 'value1', 'key2': 'value2'} | ||
| result = requests.put( | ||
| BRIDGE_URL_BASE.format( | ||
| '/api/username/lights/{}/state'.format("light.ceiling_lights")), |
There was a problem hiding this comment.
- 80: E501 line too long (80 > 79 characters)
balloobbot
reviewed
Oct 26, 2016
| """Test the allowed methods.""" | ||
| result = requests.get( | ||
| BRIDGE_URL_BASE.format( | ||
| '/api/username/lights/{}/state'.format("light.ceiling_lights"))) |
There was a problem hiding this comment.
- 80: E501 line too long (80 > 79 characters)
balloobbot
reviewed
Oct 26, 2016
| # Test proper on value parsing | ||
| result = requests.put( | ||
| BRIDGE_URL_BASE.format( | ||
| '/api/username/lights/{}/state'.format("light.ceiling_lights")), |
There was a problem hiding this comment.
- 80: E501 line too long (80 > 79 characters)
balloobbot
reviewed
Oct 26, 2016
| # Test proper brightness value parsing | ||
| result = requests.put( | ||
| BRIDGE_URL_BASE.format( | ||
| '/api/username/lights/{}/state'.format("light.ceiling_lights")), |
There was a problem hiding this comment.
- 80: E501 line too long (80 > 79 characters)
balloobbot
reviewed
Oct 26, 2016
| self.assertEqual(result.status_code, 400) | ||
|
|
||
| def perform_put_test_on_ceiling_lights(self, | ||
| content_type='application/json'): |
There was a problem hiding this comment.
- 42: E128 continuation line under-indented for visual indent
Previously these tests relied on the mqtt light platform as test devices to control with the emulated hue. However, this was pretty heavyweight and required running an MQTT broker in the tests. Instead this commit switches it to use the demo light platform which is strictly in memory. Fixes home-assistant#3549
|
Oops, forgot to run the lint checks before I pushed it. The new rev should fix the issues |
|
Yes! Thanks so much 🐬 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Previously these tests relied on the mqtt light platform as test devices
to control with the emulated hue. However, this was pretty heavyweight
and required running an MQTT broker in the tests. Instead this commit
switches it to use the demo light platform which is strictly in memory
Related issue (if applicable): fixes #3549
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass