8000 Fix connection validation during import for dsmr integration by RobBie1221 · Pull Request #40548 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix connection validation during import for dsmr integration #40548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 24, 2020
Merged

Fix connection validation during import for dsmr integration #40548

merged 2 commits into from
Sep 24, 2020

Conversation

RobBie1221
Copy link
Contributor

Breaking change

Proposed change

When data is received upon connection validation, the transport is closed no matter what was in the data. This PR checks if there is an equipment identifier in the data before closing transport.

Fixes #40529

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@RobBie1221
Copy link
Contributor Author

Can this be tagged for 0.115.3?

springstan
springstan approved these changes Sep 24, 2020
View reviewed changes
Copy link
Member
@springstan springstan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👌 sure we can tag this for 0.115.3.

@springstan springstan added this to the 0.115.3 milestone Sep 24, 2020
@springstan springstan merged commit 0856c72 into home-assistant:dev Sep 24, 2020
@RobBie1221
Copy link
Contributor Author

Thanks!

@RobBie1221 RobBie1221 deleted the dsmr_fix_conn_validate branch September 25, 2020 04:32
frenck pushed a commit that referenced this pull request Sep 25, 2020
@RobBie1221 @frenck
Fix connection validation during import for dsmr integration (#40548)
6bd72c3 
* Close transport when equipment identifier is received

* Minor fix
This was referenced Sep 25, 2020
Merged
Merged
Merged
@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@springstan springstan springstan approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed integration: dsmr small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.115.3
Development

Successfully merging this pull request may close these issues.

DSMR over IP is not picking up anymore
4 participants
@RobBie1221 @springstan @frenck @homeassistant
0