8000 Catch OSError during device update in Shelly integration by bieniu · Pull Request #40393 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Catch OSError during device update in Shelly integration #40393 8000

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2020
Merged

Catch OSError during device update in Shelly integration #40393

merged 1 commit into from
Sep 21, 2020

Conversation

bieniu
Copy link
Member
@bieniu bieniu commented Sep 21, 2020

Breaking change

Proposed change

This PR adds catching OSError during device update. The exception is described in the comment #40276 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @balloob, mind taking a look at this pull request as its been labeled with an integration (shelly) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@springstan
Copy link
Member

@bieniu should we tag this for 0.115.3?

@bieniu
Copy link
Member Author
bieniu commented Sep 21, 2020

I think, yes.

@springstan springstan added this to the 0.115.3 milestone Sep 21, 2020
@springstan springstan merged commit 663245c into home-assistant:dev Sep 21, 2020
@bieniu bieniu deleted the shelly-oserror branch September 21, 2020 22:10
This was referenced Sep 22, 2020
Closed
Closed
frenck pushed a commit that referenced this pull request Sep 25, 2020
@bieniu @frenck
Fix OSError (#40393)
b1ac920
This was referenced Sep 25, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@springstan springstan springstan approved these changes

Assignees

@balloob balloob

Labels
bugfix by-code-owner cherry-picked cla-signed integration: shelly small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.115.3
Development

Successfully merging this pull request may close these issues.
5 participants
@bieniu @springstan @frenck @balloob @homeassistant
0