8000 Bump pyinsteon to 1.0.8 by teharris1 · Pull Request #40383 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Bump pyinsteon to 1.0.8 #40383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2020
Merged

Bump pyinsteon to 1.0.8 #40383

merged 1 commit into from
Sep 21, 2020

Conversation

teharris1
Copy link
Contributor
@teharris1 teharris1 commented Sep 20, 2020 •
edited by MartinHjelmare
Loading

Proposed change

Fix issues with IOLinc and On/Off Outlet status displaying at startup. This fix upgrade the pyinsteon module to 1.0.8.

Release notes: https://github.com/pyinsteon/pyinsteon/releases/tag/1.0.8
Changelog: pyinsteon/pyinsteon@1.0.7...1.0.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title Insteon bug fixes Bump pyinsteon to 1.0.8 Sep 21, 2020
MartinHjelmare
MartinHjelmare approved these changes Sep 21, 2020
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare
Copy link
Member

Should this go out in a patch release?

@teharris1
Copy link
Contributor Author

Yes, it does not add any functionality.

@MartinHjelmare MartinHjelmare added this to the 0.115.3 milestone Sep 21, 2020
@MartinHjelmare MartinHjelmare merged commit f78391c into home-assistant:dev Sep 21, 2020
@teharris1
Copy link
Contributor Author

FYI, this fixes two existing issues in HA but the bot seems to only attach to the first issue. Did I correctly identify the issues that this addresses?

@MartinHjelmare
Copy link
Member

I edited the description to mark both issues to be fixed by this PR. Each issue number needs to be prefixed with fixes to have them linked and marked for closing.

frenck pushed a commit that referenced this pull request Sep 25, 2020
@teharris1 @frenck
Bump pyinsteon to 1.0.8 (#40383)
1901cc9
This was referenced Sep 25, 2020
Merged
Merged
Merged
@teharris1 teharris1 deleted the patch8 branch October 9, 2020 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency-bump integration: insteon small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.115.3
Development

Successfully merging this pull request may close these issues.

Insteon: I/O Linc - Garage Door Status settings issue with HASS Insteon integration shows incorrect state for bottom on/off outlet
4 participants
@teharris1 @MartinHjelmare @frenck @homeassistant
0