8000 Fix Met.no missing conditions in API forecasts by thimic · Pull Request #40373 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Met.no missing conditions in API forecasts #40373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 20, 2020
Merged

Fix Met.no missing conditions in API forecasts #40373

merged 1 commit into from
Sep 20, 2020

Conversation

thimic
Copy link
Contributor
@thimic thimic commented Sep 20, 2020

Breaking change

Proposed change

Fix for #40325. Checking for forecast key 'condition', rather than assuming it's always there.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Set up through UI.

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added bugfix integration: met small-pr PRs with less than 30 lines. labels Sep 20, 2020
@MartinHjelmare MartinHjelmare changed the title Met.no: Fix for missing conditions in API forecasts Fix Met.no missing conditions in API forecasts Sep 20, 2020
MartinHjelmare
MartinHjelmare approved these changes Sep 20, 2020
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare added this to the 0.115.3 milestone Sep 20, 2020
@MartinHjelmare MartinHjelmare merged commit 83b0954 into home-assistant:dev Sep 20, 2020
@thimic thimic mentioned this pull request Sep 21, 2020
Merged
21 tasks
frenck pushed a commit that referenced this pull request Sep 25, 2020
@thimic @frenck
Fix Met.no missing conditions in API forecasts (#40373)
babaf48
This was referenced Sep 25, 2020
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
bugfix by-code-owner cherry-picked cla-signed integration: met small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.115.3
Development

Successfully merging this pull request may close these issues.

Met.no fails to setup
5 participants
@thimic @MartinHjelmare 3559 @frenck @Danielhiversen @homeassistant
0