8000 Fix Vizio async_unload_entry bug by raman325 · Pull Request #40210 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Fix Vizio async_unload_entry bug #40210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 18, 2020
Merged

Fix Vizio async_unload_entry bug #40210

merged 1 commit into from
Sep 18, 2020

Conversation

raman325
Copy link
Contributor
@raman325 raman325 commented Sep 18, 2020 •
edited
Loading

Proposed change

When unloading an entry and there are no other remaining vizio entries with a device class of tv, async_unload_entry fails because it tries to pop a key that doesn't exist. This will prevent that call from failing (the test I added would fail before the change).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@raman325 raman325 changed the title Fix Vizio unload_entry bug Fix Vizio async_unload_entry bug Sep 18, 2020
@raman325 raman325 added this to the 0.115.1 milestone Sep 18, 2020
MartinHjelmare
MartinHjelmare approved these changes Sep 18, 2020
View reviewed changes
Copy link
Member
@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare merged commit d0a5fed into home-assistant:dev Sep 18, 2020
balloob pushed a commit that referenced this pull request Sep 18, 2020
@raman325 @balloob
Fix Vizio async_unload_entry bug (#40210)
0383030
@balloob balloob mentioned this pull request Sep 18, 2020
Merged
@raman325 raman325 deleted the vizio_unload branch September 18, 2020 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed has-tests integration: vizio small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.115.1
Development

Successfully merging this pull request may close these issues.
4 participants
@raman325 @MartinHjelmare @balloob @homeassistant
0