8000 Log template listeners when debug logging is on by bdraco · Pull Request #40180 · home-assistant/core · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Log template listeners when debug logging is on #40180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Sep 17, 2020
Merged

Log template listeners when debug logging is on #40180

merged 5 commits into from
Sep 17, 2020

Conversation

bdraco
Copy link
Member
@bdraco bdraco commented Sep 17, 2020

Proposed change

Log template listeners when debug logging is on

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added core small-pr PRs with less than 30 lines. labels Sep 17, 2020
balloob
balloob reviewed Sep 17, 2020
View reviewed changes
@bdraco bdraco added this to the 0.115.1 milestone Sep 17, 2020
amelchio
amelchio approved these changes Sep 17, 2020
View reviewed changes
Copy link
Contributor
@amelchio amelchio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this, it seems like a nice improvement. The information is probably too low level for many but being able to provide logs could make troubleshooting much easier anyway.

@bdraco
Copy link
Member Author
bdraco commented Sep 17, 2020

Thanks for testing @amelchio 👍

@bdraco bdraco merged commit e9abb35 into home-assistant:dev Sep 17, 2020
@bdraco bdraco deleted the log_listeners branch September 17, 2020 19:45
balloob pushed a commit that referenced this pull request Sep 18, 2020
@bdraco @balloob
Log template listeners when debug logging is on (#40180)
7cb0c98
@balloob balloob mentioned this pull request Sep 18, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balloob balloob balloob left review comments

@amelchio amelchio amelchio approved these changes

Assignees
No one assigned
Labels
cherry-picked cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
0.115.1
Development

Successfully merging this pull request may close these issues.

High CPU usage on Home Assistant v0.115.0b4
4 participants
@bdraco @balloob @amelchio @homeassistant
0