8000 Add share server to server settings fragment using my website by TimoPtr · Pull Request #5431 · home-assistant/android · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
/ android Public

Add share server to server settings fragment using my website #5431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add share server to server settings fragment using my website #5431

wants to merge 1 commit into from
+60 −1

Conversation

TimoPtr
Copy link
Collaborator
@TimoPtr TimoPtr commented Jun 20, 2025 •
edited
Loading

Summary

Add a share button in the server settings screen.

Checklist

  • New or updated tests have been added to cover the changes following the testing guidelines.
  • The code follows the project's code style and best_practices.
  • The changes have been thoroughly tested, and edge cases have been considered.
  • Changes are backward compatible whenever feasible. Any breaking changes are documented in the changelog for users and/or in the code for developers depending on the relevance.

Screenshots

image

Any other notes

Should be merged after #5425

@TimoPtr TimoPtr marked this pull request as ready for review June 20, 2025 14:47
dshokouhi
dshokouhi approved these changes Jun 20, 2025
View reviewed changes
Copy link
Member
@dshokouhi dshokouhi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dshokouhi dshokouhi dshokouhi approved these changes

Assignees
No one assigned
Labels
cla-signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TimoPtr @dshokouhi
0