Validate app name in templates & add support for validating pear init -y
#718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…unchto#701) * add unignore, ignore globs, purge * OOP adjustment * globs -> glob * lint * generate ignore function in method * restore test/index.js * commit changes on 0f80019 * Apply suggestions from code review * remove old entrypoints * fix test, rename method call * via support + state improvements * via: close with pipe.end(), timeout, ignore io, correct cwd + rm dupe error output * touch fix, test alignment * fix tests * lint --------- Co-authored-by: David Mark Clements <david.mark.clements@gmail.com>
* pear-ipc dev * pear data manifest + pear drop * link validation into model * Solve review comments * label `version` * remove else (paparam bug) * pear-ipc 6.0.0 * plan(17) --------- Co-authored-by: David Mark Clements <david.mark.clements@gmail.com>
* typo reseting -> resetting * file:// support * pear reset: deprecated * Bare.exit(1)
This validation is directly copied from `validateAppName()` where names are checked by Pear.
fb0adf5 to
d8ad61f
Compare
4877834 to
c60ff08
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevents default
nameproperty from being invalid fordesk 10000 topandterminaltype applications. With out the validation there are scenarios where default values can error once a user tries to run a Pear app which throws:This revealed an issue with
pear-api's processing of params when the--yesflag was set as well. So a full fix depends on holepunchto/pear-api#31