8000 chore(profile): add profile for naran-lhagvasuren by bzyfuzy · Pull Request #81 · holdex/trial · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

chore(profile): add profile for naran-lhagvasuren #81

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

chore(profile): add profile for naran-lhagvasuren #81

wants to merge 6 commits into from

Conversation

bzyfuzy
Copy link
@bzyfuzy bzyfuzy commented Mar 3, 2025 •
edited by coderabbitai bot
Loading

Resolves #64

Adds profile details to profile-submission.json

Summary by CodeRabbit

Summary by CodeRabbit

  • New Features
    • Expanded team profiles by adding a new member, Naran Lhagvasuren, to reflect our current team composition.

@bzyfuzy
chore(profile): add profile for naran-lhagvasuren
f106cc8 
Signed-off-by: BzY*FuZy <132327848+bzyfuzy@users.noreply.github.com>
@coderabbitai coderabbitai
Copy link
coderabbitai bot commented Mar 3, 2025 •
edited
Loading

"""

Walkthrough

This change updates the profile-submission.json file by adding a new team member entry to the team_profiles array. The new entry includes the GitHub handle "bzyfuzy", the full name "Naran Lhagvasuren", and a link to a GitHub trial issue. The change expands the list of existing team profiles.

Changes

File Change Summary
profile-submission.json Added a new entry to the team_profiles array with:
- github_handle: "bzyfuzy"
- full_name: "Naran Lhagvasuren"
- github_trial_issue_link: "#64"

Assessment against linked issues

Objective Addressed Explanation
Add new team member Naran Lhagvasuren (64) ✅

Possibly related PRs

  • chore(profile): add profile for Luqmanul Hakim #131: The changes in the main PR and the retrieved PR both involve modifications to the team_profiles array in the profile-submission.json file, with each adding a new profile entry; thus, they are related.
  • chore(profile): add profile for Shadab Khan #79: The changes in the main PR and the retrieved PR both involve adding new entries to the team_profiles array in the profile-submission.json file, indicating a direct modification to the same structure.
  • chore(profile): update team profiles #122: The changes in the main PR and the retrieved PR both involve adding new entries to the team_profiles array in the profile-submission.json file, indicating a direct modification to the same structure.

Suggested reviewers

  • zolotokrylin
  • markholdex
    """
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 20b84b9 and e2feb5d.

📒 Files selected for processing (1)
  • profile-submission.json (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • profile-submission.json
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

tiffmyaaw
tiffmyaaw requested changes Mar 18, 2025
View reviewed changes
Copy link
Contributor
@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzyfuzy please resolve conflicts, and edit your PR description based on this guide

@bzyfuzy
Merge branch 'main' into main
3242fb9 
Signed-off-by: BzY*FuZy <132327848+bzyfuzy@users.noreply.github.com>
coderabbitai[bot]
coderabbitai bot reviewed Mar 19, 2025
View reviewed changes
Copy link
@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f106cc8 and 3242fb9.

📒 Files selected for processing (1)
  • profile-submission.json (1 hunks)
🧰 Additional context used
🪛 Biome (1.9.4)
profile-submission.json

[error] 24-24: The key github_handle was already declared.

This where a duplicated key was declared again.

If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.

(lint/suspicious/noDuplicateObjectKeys)

[error] 25-25: The key full_name was already declared.

This where a duplicated key was declared again.

If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.

(lint/suspicious/noDuplicateObjectKeys)

[error] 26-26: The key github_trial_issue_link was already declared.

This where a duplicated key was declared again.

If a key is defined multiple times, only the last definition takes effect. Previous definitions are ignored.

(lint/suspicious/noDuplicateObjectKeys)

@bzyfuzy
Copy link
Author
bzyfuzy commented Mar 19, 2025

@tiffmyaaw conflicts Resolved

zolotokrylin
zolotokrylin requested changes Mar 19, 2025
View reviewed changes
Copy link
Member
@zolotokrylin zolotokrylin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have an error in your code. You have the wrong JSON structure.

bzyfuzy added 2 commits March 19, 2025 17:11
@bzyfuzy
fix(profile): json syntax fixed
20b84b9 
Signed-off-by: BzY*FuZy <132327848+bzyfuzy@users.noreply.github.com>
@bzyfuzy
Merge branch 'main' into main
3a05d4a
@bzyfuzy
Copy link
Author
bzyfuzy commented Mar 20, 2025

@tiffmyaaw, @zolotokrylin, @markholdex JSON structure resolved

tiffmyaaw
tiffmyaaw requested changes Mar 25, 2025
View reviewed changes
Copy link
Contributor
@tiffmyaaw tiffmyaaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@bzyfuzy your PR description should be using close / closes as you're solving the issue within the same repo, read again

@bzyfuzy
Copy link
Author
bzyfuzy commented Mar 26, 2025

Nah, you guys are way too bureaucratic!

@tiffmyaaw
Copy link
Contributor

I'll close this PR then as the applicant has stated that he wants to withdraw

@tiffmyaaw tiffmyaaw closed this Mar 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@coderabbitai coderabbitai[bot] coderabbitai[bot] left review comments

@tiffmyaaw tiffmyaaw tiffmyaaw requested changes

@markholdex markholdex Awaiting requested review from markholdex

@zolotokrylin zolotokrylin Awaiting requested review from zolotokrylin

Assignees

@bzyfuzy bzyfuzy

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Fullstack Engineer] Naran Lhagvasuren
3 participants
@bzyfuzy @tiffmyaaw @zolotokrylin
0