Implement smarter Column child rendering #7846
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mattpap question for you, do you have any major concerns with this and would you be opposed to upstreaming something like this in Bokeh? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #7846 +/- ##
==========================================
- Coverage 87.09% 86.07% -1.03%
==========================================
Files 346 346
Lines 52947 53014 +67
==========================================
- Hits 46116 45633 -483
- Misses 6831 7381 +550 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
As long as order is maintained, this is fine. In fact, I would prefer to have a non-removing approach in bokeh. |
|
Okay, will upstream shortly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
LayoutDOMimplementation in Bokeh removes child DOM nodes and then re-adds them. This is problematic for certainReactbased scenarios where detaching a DOM node and re-attaching it can make React lose track of certain internal state. Therefore we re-implement theupdate_layoutimplementation here to avoid removing elements and instead insert the new children in the appropriate locations.