Upgrade Quill to version 2.0.2 and fix toolbar editing and nested lists #7739
Conversation
|
pre-commit.ci autofix |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #7739 +/- ##
==========================================
+ Coverage 86.11% 87.21% +1.09%
==========================================
Files 346 346
Lines 52828 52843 +15
==========================================
+ Hits 45492 46085 +593
+ Misses 7336 6758 -578 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Failing UI test is unrelated. I've been trying to run the example notebook locally but without luck due to another bug in how resources are handled in a local development setting. We discussed whether merging a PR like this one should be part of a patch release (incoming 1.6.2) or a minor release (1.7). I think it's okay if it is released in 1.6.2 as after all this is just affecting one specific widget, which has a blast radius much smaller than the new compatibility to Bokeh 3.7. What is annoying with this widget is that it is already broken in various ways (I just found out the bubble version doesn't seem to work, at least on the website) but it does have a few UI tests that can catch potential regressions, and from my own testing I saw no new bug introduced by this PR. (I guess it wouldn't be a bad idea for me to start working on a new panel extension that leverages another JS rich text editor to see if we can get something better than this one) |
for more information, see https://pre-commit.ci
Fixes #7524
Fixes #7460
By upgrading Quill to version 2.0.2. Note the latest is 2.0.3 but has a weird bug that replaces all white spaces with
nbsp;. The testtest_texteditor_nested_listsfailed before this PR and now passes. I've also run the tests locally on Firefox and they all pass, one needed some adjustment.Keeping it a bit in Draft mode as I'd like to test it on a real app (I'm moderately confident on Quill's robustness and v2 still doesn't support the virtual DOM).