8000 fix: Check if connection has a name before comparing with connection query by alexluong · Pull Request #83 · hookdeck/hookdeck-cli · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
Dismiss alert

fix: Check if connection has a name before comparing with connection query #83

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 5, 2024
Merged

fix: Check if connection has a name before comparing with connection query #83

merged 1 commit into from
Jun 5, 2024

Conversation

alexluong
Copy link
Collaborator

When we run hookdeck listen 1234 source-name connection-name, if the source has a connection without a name, it may run into nil pointer issue. This PR will check to make sure the pointer exists first before dereference it.

@alexluong
Copy link
Collaborator Author
alexluong commented Jun 4, 2024 •
edited
Loading

@leggetter @alexbouchardd do we need to increment the package.json version on every PR?

https://github.com/hookdeck/hookdeck-cli/actions/runs/9369372921/job/25793802510

CleanShot 2024-06-04 at 21 57 33

@alexbouchardd
Copy link
Contributor

@leggetter The action seems to be running for every branch?

@alexluong alexluong mentioned this pull request Jun 5, 2024
Closed
@leggetter
Copy link
Collaborator
leggetter commented Jun 5, 2024 •
edited
Loading

@leggetter leggetter merged commit a679609 into main Jun 5, 2024
4 checks passed
@leggetter leggetter deleted the connection-name branch June 5, 2024 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexbouchardd alexbouchardd alexbouchardd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@alexluong @alexbouchardd @leggetter
0

@leggetter The action seems to be running for every branch?

The release GitHub workflow should only trigger when new tags are pushed:
https://github.com/hookdeck/hookdeck-cli/blob/main/.github/workflows/release.yml#L3-L6

The test workflow should run when there's a PR to main https://github.com/hookdeck/hookdeck-cli/blob/connection-name/.github/workflows/test.yml#L3-L6

Following semver, the next released version should be v0.10.1 if this is a patch fix..