8000 (CodeQL) Removed printing/sending of error data by pixeebot-helm-test[bot] · Pull Request #1 · hintwatermelon/roller3 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

(CodeQL) Removed printing/sending of error data #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pixeebot-helm-test[bot]
Copy link

Remediation

This change fixes findings identified by CodeQL.

Details

This change removes exposure through sending/printing of error and exception data.

Our changes look like this:

 void function(HttpServletResponse response) {
    PrintWriter pw = reponse.getWriter();
    try{
        ...
    } catch (Exception e) {
-        pw.println(e.getMessage());
    }
 }
More reading

I have additional improvements ready for this repo! If you want to see them, leave the comment:

@pixeebot next

... and I will open a new PR right away!

🧚🤖 Powered by Pixeebot

Feedback | Community | Docs | Codemod ID: codeql:java/error-message-exposure

Copy link
Author

I'm confident in this change, and the CI checks pass, too!

If you see any reason not to merge this, or you have suggestions for improvements, please let me know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants
0