[Operator] Add conv3d, max_pool3d, avg_pool3d #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @hjjq, thanks for the quick PR. I prefer to making a general version convolution operator that support arbitrary number of spatial dimensions n (n >= 1) and subclass them to get the 1d, 2d, and 3d versions of tasks. This would avoid most of the repeatition. I will let you to decide:
|
|
Thanks Yaoyao, I will merge and refactor later. |
KTong821
pushed a commit
to KTong821/hidet
that referenced
this pull request
Apr 24, 2024
Instead of mocking a ctypes type like `c_pointer_compatible`, these changes make the transformation from Python values <> ctypes values more explicit with direct function calls inside of `CompiledFunction`.
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 22, 2024
Instead of mocking a ctypes type like `c_pointer_compatible`, these changes make the transformation from Python values <> ctypes values more explicit with direct function calls inside of `CompiledFunction`.
vadiklyutiy
pushed a commit
that referenced
this pull request
Jul 23, 2024
Instead of mocking a ctypes type like `c_pointer_compatible`, these changes make the transformation from Python values <> ctypes values more explicit with direct function calls inside of `CompiledFunction`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolve
2BFD
d.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.