Ensure tracing export data is newline-separated #926
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colincasey
approved these changes
Mar 25, 2025
colincasey
added a commit
that referenced
this pull request
Apr 16, 2025
* main: Update petgraph requirement from 0.7.1 to 0.8.1 (#934) Update repo metadata (#933) Add `tracing-opentelemetry` to the OTel crate Dependabot group (#931) Bump the github-actions group with 2 updates (#928) Prepare release v0.28.1 (#927) Ensure tracing export data is newline-separated (#926) Use `--locked` with Cargo where possible (#925) Pin SHA of third-party GitHub Actions (#923) Reduce scopes granted to `GITHUB_TOKEN` in GitHub Actions workflows (#924)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When exporting tracing data batches multiple times (this happens when there more spans in the queue than the batch size), the JSON objects are incorrectly on the same line. This prevents JSONL parsers (like cnb-otel-collector) from working, as they expect valid JSON objects on each line.
To fix this, we insert a
\nafter each export batch.Thanks @colincasey for uncovering this bug.