8000 Refactor `libcnb-cargo` by Malax · Pull Request #657 · heroku/libcnb.rs · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Refactor libcnb-cargo #657

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 29, 2023
Merged

Refactor libcnb-cargo #657

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
33b87d9
Refactor libcnb-cargo
Malax Aug 25, 2023
1d31faf
Add docs and tests for normalize_path
Malax Aug 29, 2023
645a872
Remove outdated comment about fs_extra usage
Malax Aug 29, 2023
80f2ada
Typo fixes
Malax Aug 29, 2023
1c1ebea
Add CHANGELOG entries
Malax Aug 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,9 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
### Changed

- Renamed `libcnb-data`'s `Buildpackage` to `PackageDescriptor`. This required changes in many other names across multiple libcnb.rs crates for consistency. See the PR diff for details, but renames should be straightforward and unsurprising. ([#656](https://github.com/heroku/libcnb.rs/pull/656))
- `libcnb-cargo`:
- No longer outputs paths for non-libcnb.rs and non-meta buildpacks. ([#657](https://github.com/heroku/libcnb.rs/pull/657))
- Build output for humans changed slightly, output intended for machines/scripting didn't change. ([#657](https://github.com/heroku/libcnb.rs/pull/657))

## [0.14.0] - 2023-08-18

Expand Down
2 changes: 0 additions & 2 deletions libcnb-cargo/Cargo.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,6 @@ name = "cargo-libcnb"
path = "src/main.rs"

[dependencies]
cargo_metadata = "0.17.0"
clap = { version = "4.3.22", default-features = false, features = [
"derive",
"error-context",
Expand All @@ -28,7 +27,6 @@ libcnb-data.workspace = true
libcnb-package.workspace = true
pathdiff = "0.2.1"
thiserror = "1.0.47"
toml.workspace = true

[dev-dependencies]
tempfile = "3.7.1"
6 changes: 3 additions & 3 deletions libcnb-cargo/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,13 +4,13 @@
// This lint is too noisy and enforces a style that reduces readability in many cases.
#![allow(clippy::module_name_repetitions)]

mod cli;
mod package;

// Suppress warnings due to the `unused_crate_dependencies` lint not handling integration tests well.
#[cfg(test)]
use tempfile as _;

mod cli;
mod package;

use crate::cli::{Cli, LibcnbSubcommand};
use clap::Parser;

Expand Down
Loading
0