8000 feat: migrate aarch64 to fdt crate by fstracke · Pull Request #465 · hermit-os/loader · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

feat: migrate aarch64 to fdt crate #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 13, 2025

Conversation

fstracke
Copy link
Contributor

The aarch64 implementation relied on the hermit-dtb crate. Migrate to the more widespread fdt crate.

@mkroening mkroening self-requested a review June 12, 2025 13:03
@mkroening mkroening self-assigned this Jun 12, 2025
@fstracke fstracke force-pushed the feat-fdt-migration branch from 4f36472 to 407d6a6 Compare June 12, 2025 13:07
Copy link
Member
@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks good! I have a few requests, though. :)

@fstracke fstracke force-pushed the feat-fdt-migration branch from 407d6a6 to 29910f9 Compare June 13, 2025 08:02
@fstracke fstracke requested a review from mkroening June 13, 2025 08:06
Copy link
Member
@mkroening mkroening left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! :)

The aarch64 implementation relied on the hermit-dtb crate. Migrate to
the more widespread fdt crate.
@mkroening mkroening force-pushed the feat-fdt-migration branch from 29910f9 to f1c3c70 Compare June 13, 2025 15:13
@mkroening
Copy link
Member

I rebased and squashed :)

@mkroening mkroening added this pull request to the merge queue Jun 13, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jun 13, 2025
@fstracke
Copy link
Contributor Author

I think the pipeline failed during merge due to connection issues; Maybe resubmit?

@mkroening mkroening added this pull request to the merge queue Jun 13, 2025
Merged via the queue into hermit-os:main with commit 9d3c940 Jun 13, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0