8000 Remote Location Assert (HIP12, merged) by rawrmaan · Pull Request #30 · helium/HIP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Remote Location Assert (HIP12, merged) #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 26, 2020
Merged

Remote Location Assert (HIP12, merged) #30

merged 2 commits into from
Aug 26, 2020

Conversation

rawrmaan
Copy link
Contributor

Since the GPS location assertion check will soon be enforced, more than 1500 hotspots will need to be adjusted in some way in order to have a good GPS fix and continue participating in Proof of Coverage (see current hotspot gps_fix_quality states below). For many hotspots, this will require updating the asserted location to accurately reflect the hotspot's latest location, which can currently only be done with physical access to the hotspot.

gps_fix_quality | count 
----------------+-------
good_fix        |  2275
no_fix          |  1090
bad_assert      |   514

This HIP proposes a new transaction, assert_location_v2, which will allow a hotspot's location to be asserted remotely without physical access to the hotspot.

@jamiew
Copy link
Contributor
jamiew commented Jun 19, 2020

As a HIP this looks good to me and I'd vote to merge for discussion (and code)

@abhay
Copy link
Contributor
abhay commented Jun 25, 2020

Can we merge and continue discussion, @PharkMillups @vihu ?

vihu
vihu reviewed Jun 25, 2020
View reviewed changes
vihu
vihu reviewed Jun 25, 2020
View reviewed changes
vihu
vihu approved these changes Jun 26, 2020
View reviewed changes
Copy link
Contributor
@vihu vihu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for putting this up, stamped 👍

@jamiew jamiew added the draft label Jul 3, 2020
@jamiew
Copy link
Contributor
jamiew commented Aug 25, 2020

@rawrmaan I was too slow to merge this and now we have a HIP10 and draft HIP11 and HIP12. How insulted would you be if I number this HIP13, despite predating all 3 of those? Could also number this 11 and renumber 12 and 13

@jamiew jamiew changed the title Remote Location Assert HIP(x): Remote Location Assert Aug 25, 2020
@rawrmaan
Copy link
Contributor Author

@jamiew How will my friends and family respect me if this can't be HIP10, 11, or 12? This is devastating.

I suppose I'll have to settle for 13 and regain my honor through other feats.

@abhay
Copy link
Contributor
abhay commented Aug 25, 2020

Haha. @rawrmaan. Also should rescope this for large scale deployers of gateways and establishing a way for them to manage their hotspots since the GPS fix data is not going to be used.

I think it's still a worthwhile HIP that should be accepted for discussion.

@rawrmaan
Copy link
Contributor Author
rawrmaan commented Aug 26, 2020 •
edited
Loading

@abhay How would you recommend we rescope this? I think the feature is still relevant as it is laid out. GPS may not matter, but hosts need to place their hotspots in the correct spots on the map if they move, or they will not be able to PoC with nearby hotspots.

EDIT: Never mind, I get what you're saying. I'll have time to do this next week.

@jamiew jamiew merged commit dd445c8 into helium:master Aug 26, 2020
@jamiew jamiew changed the title HIP(x): Remote Location Assert HIP13: Remote Location Assert Aug 26, 2020
This was referenced Aug 26, 2020
Closed
Merged
@jamiew
Copy link
Contributor
jamiew commented Aug 26, 2020

Just kidding, this is actually HIP12

@jamiew jamiew changed the title HIP13: Remote Location Assert Remote Location Assert (HIP12, merged) Aug 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@abhay abhay abhay left review comments

@vihu vihu vihu approved these changes

Assignees
No one assigned
Labels
draft
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rawrmaan @jamiew @abhay @vihu
0