8000 Initial template for applications to be a third-party manufacturer by shawaj · Pull Request #92 · helium/HIP · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Initial template for applications to be a third-party manufacturer #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8000 Jump to bottom
Merged
merged 5 commits into from
Dec 11, 2020
Merged

Initial template for applications to be a third-party manufacturer #92

merged 5 commits into from
Dec 11, 2020

Conversation

shawaj
Copy link
Contributor
@shawaj shawaj commented Dec 10, 2020

Initial attempt at a template

I guess we could put in the draft / template some guides as to what to put in each section?

@shawaj
Initial discussion of template
b0f5179 
Initial attempt at a template
@shawaj shawaj changed the title Initial discussion of template Initial discussion of template nanufacturer application Dec 10, 2020
@shawaj shawaj changed the title Initial discussion of template nanufacturer application Initial discussion of template manufacturer application Dec 10, 2020
@jamiew
Copy link
Contributor
jamiew commented Dec 10, 2020

Oh very nice, thanks. I had just DM'd you a draft of the template I started in Google Docs: https://docs.google.com/document/d/1zRM3V07gdciyms0c8qaVqIyIZy7CpkcpN3qsb6OY7kA/edit

Happy to join forces

Also love idea of putting both this template and future applications into a /hip-19-.../ directory in the repo 👍

@jamiew jamiew changed the title Initial discussion of template manufacturer application Initial template for applications to be a third-party manufacturer Dec 10, 2020
@shawaj
Update based on comments to PR
e9e247f 
Based on comments on the pr here... helium#92 (comment)
@shawaj
Copy link
Contributor Author
shawaj commented Dec 11, 2020

@jamiew added a new commit to effectively merge what you did on the drive doc and what was in mine. Think it looks pretty good, if I may say so myself 😛

Can squash the commits when the time comes.

@shawaj
Rename to template
3b00060 
Rename from draft to template
@shawaj shawaj mentioned this pull request Dec 11, 2020
Merged
@jamiew jamiew added the draft label Dec 11, 2020
@jamiew jamiew merged commit 0f12ea4 into helium:master Dec 11, 2020
@jamiew jamiew added amendment and removed draft labels Dec 11, 2020
@fvasquez fvasquez mentioned this pull request Jan 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
amendment
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shawaj @jamiew
0