8000 bug fixes: in memory allCharts map was not updated on chart refresh by samifruit514 · Pull Request #452 · helm/monocular · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content
This repository was archived by the owner on Jul 16, 2021. It is now read-only.

bug fixes: in memory allCharts map was not updated on chart refresh #452

Merged
merged 4 commits into from
May 23, 2018
Merged

bug fixes: in memory allCharts map was not updated on chart refresh #452

merged 4 commits into from
May 23, 2018

Conversation

samifruit514
Copy link
Contributor
  • charts in memory were not updated because I was not comparing the string contents
  • updates were done on existing versions but not on new versions, which is useless since most of the time we upload a new version.

@codecov-io
Copy link
codecov-io commented May 17, 2018 •
edited
Loading

Codecov Report

Merging #452 into master will increase coverage by 0.14%.
The diff coverage is 86.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #452      +/-   ##
==========================================
+ Coverage   83.81%   83.95%   +0.14%     
==========================================
  Files          26       26              
  Lines        1532     1558      +26     
==========================================
+ Hits         1284     1308      +24     
- Misses        197      198       +1     
- Partials       51       52       +1
Impacted Files Coverage Δ
src/api/mocks/charts.go 83.5% <50%> (-1.45%) ⬇️
src/api/data/cache/cache.go 89.88% <92.3%> (+1.42%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 277e2e3...93944f5. Read the comment docs.

@samifruit514 samifruit514 mentioned this pull request May 22, 2018
Closed
prydonius
prydonius approved these changes May 23, 2018
View reviewed changes
Copy link
Member
@prydonius prydonius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice catch!

@prydonius prydonius merged commit eaaa13f into helm:master May 23, 2018
@prydonius prydonius mentioned this pull request May 30, 2018
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@prydonius prydonius prydonius approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@samifruit514 @codecov-io @prydonius
0