This repository was archived by the owner on Jul 16, 2021. It is now read-only.
fixes fetching relative chart urls from index #388
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Helm supports repository indexes that use relative URLs to chart packages (formed by omitting the --url flag in `helm repo index`). This patch enables Monocular to do the same.
Codecov Report
@@ Coverage Diff @@
## master #388 +/- ##
==========================================
+ Coverage 89.39% 89.44% +0.05%
==========================================
Files 19 19
Lines 792 796 +4
==========================================
+ Hits 708 712 +4
Misses 56 56
Partials 28 28
Continue to review full report at Codecov.
|
When passing the url.URL pointer, we're continuously appending to the same path. By re-creating the url.URL var each time we ensure we only append to the base repo URL.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Helm supports repository indexes that use relative URLs to chart
packages (formed by omitting the --url flag in
helm repo index). Thispatch enables Monocular to do the same.
Fixes #387