This repository was archived by the owner on Jul 16, 2021. It is now read-only.
ui: make app version most prominent #322
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
- fixes chart version showing instead of appVersion #318 - a mistake where the chart version is mistakenly shown instead of the intended app version
- makes the app version more prominent in the chart details page below the name and logo
Angelmmiguel
approved these changes
Jul 21, 2017
| @@ -7,7 +7,7 @@ <h2 class="chart-item-info__title"> | |||
| </h2> | |||
| <p> | |||
| <span class="chart-item-info__version" *ngIf="showVersion && chart.relationships.latestChartVersion.data.app_version"> | |||
| {{ chart.relationships.latestChartVersion.data.version }}</span> | |||
| {{ chart.relationships.latestChartVersion.data.app_version }}</span> | |||
There was a problem hiding this comment.
mmm I think it was a typo error 😂
Codecov Report
@@ Coverage Diff @@
## master #322 +/- ##
=======================================
Coverage 88.99% 88.99%
=======================================
Files 15 15
Lines 618 618
=======================================
Hits 550 550
Misses 45 45
Partials 23 23Continue to review full report at Codecov.
|
|
Still LGTM :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.