8000 Add option to not mark GitHub release as latest by der-eismann · Pull Request #237 · helm/chart-releaser · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Add option to not mark GitHub release as latest #237

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 5, 2023
Merged

Add option to not mark GitHub release as latest #237

merged 1 commit into from
Jan 5, 2023

Conversation

der-eismann
Copy link
Contributor

Hey everyone! This PR adds an option to not mark created releases as "latest" on GitHub. The default is true, so the existing behavior isn't changed.

Reasoning: I use gitpunch.com to follow repos for their latest releases, but the same goes for people who curl the repos/<owner>/<repo>/releases/latest API on GitHub. A new helm chart is less interesting than a new release of the software itself, so it shouldn't draw attention away from it.

I'm also open for different wording 🙂

@der-eismann der-eismann changed the title Add option to not mark GitHub release as latets Add option to not mark GitHub release as latest Dec 15, 2022
@cpanato
Copy link
Member
cpanato commented Dec 16, 2022

@der-eismann thanks for your PR
can you please sign the DCO? thanks

@der-eismann
Copy link
Contributor Author

@der-eismann thanks for your PR can you please sign the DCO? thanks

Done!

@der-eismann
Copy link
Contributor Author

@cpanato could you please let the checks run again?

Copy link
Member
@davidkarlsen davidkarlsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase

@cpanato
Copy link
Member
cpanato commented Jan 4, 2023

@der-eismann can you please rebase? thanks!

Signed-off-by: Philipp Trulson <philipp@trulson.de>
@der-eismann
Copy link
Contributor Author

Done

@davidkarlsen davidkarlsen merged commit ee26f50 into helm:main Jan 5, 2023
@der-eismann
Copy link
Contributor Author

Thanks for merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0