8000 Allow `ammo_count` of -1. by Jupeyy · Pull Request #120 · heinrich5991/libtw2 · GitHub
[go: up one dir, main page]
More Web Proxy on the site http://driver.im/
Skip to content

Allow ammo_count of -1. #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Allow ammo_count of -1. #120

wants to merge 1 commit into from

Conversation

Jupeyy
Copy link
@Jupeyy Jupeyy commented Apr 22, 2025

@heinrich5991
Copy link
Owner

Dunno why rustfmt did what it did.

It seems whatever you're using is ignoring the #[rustfmt::skip] in lib.rs. Seems like a bug in that tool to me.

@Jupeyy
Copy link
Author
Jupeyy commented Apr 28, 2025

It seems whatever you're using is ignoring the #[rustfmt::skip] in lib.rs. Seems like a bug in that tool to me.

Also formats everything if I run it from cmd line:
rustfmt --edition=2021 gamenet/ddnet/src/snap_obj.rs

@Jupeyy Jupeyy force-pushed the pr_ammo_count_range branch from cf47e7a to 3c7a201 Compare April 28, 2025 14:50
@heinrich5991
Copy link
Owner

Also formats everything if I run it from cmd line:
rustfmt --edition=2021 gamenet/ddnet/src/snap_obj.rs

I use cargo fmt. Do you use rustfmt directly or through another tool?

@Jupeyy
Copy link
Author
Jupeyy commented Apr 28, 2025

I use cargo fmt. Do you use rustfmt directly or through another tool?

I use the rust-analyzer plugin for codium, dunno what it does internally

heinrich5991
heinrich5991 reviewed May 8, 2025
View reviewed changes
Copy link
Owner
@heinrich5991 heinrich5991 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The files you changed are generated. I changed the generation in 610f5ec. Thanks for your PR anyway. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heinrich5991 heinrich5991 heinrich5991 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ammo_count of value -1 is refused
2 participants
@Jupeyy @heinrich5991
0